Fix exponential retries on parsing error#39
Open
moritz157 wants to merge 1 commit into
Open
Conversation
|
Thank you @moritz157 for tackling this. I'm running into the same issue. @pratikbaid3 what do you think of this approach? Is this ready for merging? |
Owner
|
Hi @moritz157. Thank you for the PR. Looks good to merge. Doing some final testings to go ahead with the final merge. |
|
yep. been using it and it does fix the issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #38 as it cancels the stream subscriptions if the message parser cannot parse a line. Also it catches responses without the header
content-type: text/event-streamearly and (if no response headerconnection: keep-aliveis present) logs their body for debugging purposes.